fix precondition

mutianf · mutianf · commit 149aad079bea · 2021-02-01T20:01:54.000Z
diff --git a/gax/src/main/java/com/google/api/gax/batching/BatcherImpl.java b/gax/src/main/java/com/google/api/gax/batching/BatcherImpl.java
@@ -141,9 +141,9 @@ public BatcherImpl(
                   >= batchingSettings.getElementCountThreshold(),
           "if throttling and batching on element count are enabled, FlowController#minOutstandingElementCount must be greater or equal to elementCountThreshold");
       Preconditions.checkArgument(
-          flowControllerToUse.getMinOutstandingElementCount() == null
+          flowControllerToUse.getMinOutstandingRequestBytes() == null
               || batchingSettings.getRequestByteThreshold() == null
-              || flowControllerToUse.getMinOutstandingElementCount()
+              || flowControllerToUse.getMinOutstandingRequestBytes()
                   >= batchingSettings.getRequestByteThreshold(),
           "if throttling and batching on request bytes are enabled, FlowController#minOutstandingRequestBytes must be greater or equal to requestByteThreshold");
     }
diff --git a/gax/src/test/java/com/google/api/gax/batching/BatcherImplTest.java b/gax/src/test/java/com/google/api/gax/batching/BatcherImplTest.java
@@ -733,9 +733,9 @@ public void testConstructors() {
         new FlowController(
             DynamicFlowControlSettings.newBuilder()
                 .setLimitExceededBehavior(LimitExceededBehavior.ThrowException)
-                .setInitialOutstandingRequestBytes(100L)
-                .setMinOutstandingRequestBytes(50L)
-                .setMaxOutstandingRequestBytes(200L)
+                .setInitialOutstandingRequestBytes(5000L)
+                .setMinOutstandingRequestBytes(1000L)
+                .setMaxOutstandingRequestBytes(6000L)
                 .build());
     FlowControlEventStats events = new FlowControlEventStats();
     try {
