fix: handle already quoted protojson wkt#1294
Conversation
vchudnov-g
left a comment
vchudnov-g
left a comment
There was a problem hiding this comment.
Oh, this is getting called when parsing body fields as well? When working on #1282 I somehow convinced myself this wasn't getting called in that case and removed code I originally had to check for pre-existing parsing. Ooops. Thanks for fixing this. (And apologies for not seeing the post-merge comments on that PR; thanks for pinging me.)
I don't think so! The test error I linked to was using a Standard Update, which encodes the
All good! GitHub Notifications are kind of all over the place, I don't mind pinging (probably should've started with that tbh) |
2 participants
Since
protojsonencodes WKT with quotations already, quoting it again actually breaks parsing. This blocks gapic-generator-go's adoption of the latest release: https://github.com/googleapis/gapic-generator-go/actions/runs/4669784400/jobs/8268694956?pr=1276.Only wrap with quotes if it isn't already.