This repository was archived by the owner on Jan 18, 2026. It is now read-only.
fix: name generation when multiple packages are involved#847
Merged
alexander-fenster merged 2 commits intomasterfrom Mar 25, 2021
Merged
fix: name generation when multiple packages are involved#847alexander-fenster merged 2 commits intomasterfrom
alexander-fenster merged 2 commits intomasterfrom
Conversation
google-cla
Bot
added
the
cla: yes
| @@ -1,9 +1,4 @@ | |||
| [ | |||
| "../../protos/google/cloud/asset/v1/asset_service.proto", | |||
| "../../protos/google/cloud/asset/v1/assets.proto", | |||
Contributor
Author
There was a problem hiding this comment.
This won't change anything in the generated code.
| const packageNamesToGenerate = protoFilesToGenerate.map( | ||
| pf => pf.package || '' | ||
| ); | ||
| const protoPackagesToGenerate = new Set<string>(); |
Contributor
Author
There was a problem hiding this comment.
This fix follows #832 - this is just one more place I forgot to fix (and did not catch it because of lack of test coverage). Now this is covered by tests :)
alexander-fenster
force-pushed
the
fix-naming-pubsub
branch
from
28a8003 to
96009d1
Compare
bcoe
reviewed
Mar 25, 2021
bcoe
approved these changes
Mar 25, 2021
gcf-merge-on-green Bot
pushed a commit
that referenced
this pull request
Apr 28, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [1.3.0](https://www.github.com/googleapis/gapic-generator-typescript/compare/v1.2.11...v1.3.0) (2021-04-28) ### Features * api_dump template to use in tests ([#845](https://www.github.com/googleapis/gapic-generator-typescript/issues/845)) ([71f3ed0](https://www.github.com/googleapis/gapic-generator-typescript/commit/71f3ed045b9d3456b10a5539fd998d445acdb97d)) ### Bug Fixes * **deps:** update all packages (major), do not use get-stdin ([#855](https://www.github.com/googleapis/gapic-generator-typescript/issues/855)) ([07e645a](https://www.github.com/googleapis/gapic-generator-typescript/commit/07e645aa81e5df1e7582e6940ef911d98c1409a2)) * name generation when multiple packages are involved ([#847](https://www.github.com/googleapis/gapic-generator-typescript/issues/847)) ([9ab2a61](https://www.github.com/googleapis/gapic-generator-typescript/commit/9ab2a615be761a97d44dd6ed775cbce3842bced7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the problem with incorrect package name in Pub/Sub library (and possibly others), now with the test coverage (hence the API JSON change). After this is released, it should generate a proper config JSON.