Skip to content
This repository was archived by the owner on Jan 18, 2026. It is now read-only.

fix: remove floating promises #1697

Merged
sofisl merged 19 commits into from
Mar 18, 2025
Merged

fix: remove floating promises #1697

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
ff84aca
chore: addjson files to tsconfig
sofisl Mar 10, 2025
b1befdf
chore: update tsconfig for esm
sofisl Mar 11, 2025
16614d4
Merge branch 'main' into updateTsConfig
sofisl Mar 11, 2025
58f0033
readd .cjs to tsconfig for esm
sofisl Mar 11, 2025
5d47739
:wq
sofisl Mar 11, 2025
b92cc3f
fix: no floating promises dangling for gapics
sofisl Mar 14, 2025
3025956
Merge branch 'main' into updateLinter
sofisl Mar 14, 2025
59184e7
force push
sofisl Mar 14, 2025
e8b8abe
make esm tests pass
sofisl Mar 14, 2025
48bf09b
attempt to upgrade deps
sofisl Mar 14, 2025
bb35537
retry
sofisl Mar 14, 2025
3bea4be
update tsconfig
sofisl Mar 14, 2025
0b54a6b
retry
sofisl Mar 14, 2025
3848abd
Merge branch 'main' into updateLinter
sofisl Mar 17, 2025
df0321c
chore: revert changes to package.json
sofisl Mar 17, 2025
908168d
revertwrong changes
sofisl Mar 17, 2025
c701959
chore: fix missing authentication in client initialization, error is …
sofisl Mar 17, 2025
2e5bb2d
chore: remove typo
sofisl Mar 17, 2025
c821b86
restore changes to main
sofisl Mar 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions baselines/asset-esm/esm/src/v1/asset_service_client.ts.baseline
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,7 +473,7 @@ export class AssetServiceClient {
] = this._gaxModule.routingHeader.fromParams({
'parent': request.parent ?? '',
});
this.initialize();
this.initialize().catch(err => {throw err});
this._log.info('batchGetAssetsHistory request %j', request);
const wrappedCallback: Callback<
protos.google.cloud.asset.v1.IBatchGetAssetsHistoryResponse,
Expand Down Expand Up @@ -574,7 +574,7 @@ export class AssetServiceClient {
] = this._gaxModule.routingHeader.fromParams({
'parent': request.parent ?? '',
});
this.initialize();
this.initialize().catch(err => {throw err});
this._log.info('createFeed request %j', request);
const wrappedCallback: Callback<
protos.google.cloud.asset.v1.IFeed,
Expand Down Expand Up @@ -664,7 +664,7 @@ export class AssetServiceClient {
] = this._gaxModule.routingHeader.fromParams({
'name': request.name ?? '',
});
this.initialize();
this.initialize().catch(err => {throw err});
this._log.info('getFeed request %j', request);
const wrappedCallback: Callback<
protos.google.cloud.asset.v1.IFeed,
Expand Down Expand Up @@ -753,7 +753,7 @@ export class AssetServiceClient {
] = this._gaxModule.routingHeader.fromParams({
'parent': request.parent ?? '',
});
this.initialize();
this.initialize().catch(err => {throw err});
this._log.info('listFeeds request %j', request);
const wrappedCallback: Callback<
protos.google.cloud.asset.v1.IListFeedsResponse,
Expand Down Expand Up @@ -848,7 +848,7 @@ export class AssetServiceClient {
] = this._gaxModule.routingHeader.fromParams({
'feed.name': request.feed!.name ?? '',
});
this.initialize();
this.initialize().catch(err => {throw err});
this._log.info('updateFeed request %j', request);
const wrappedCallback: Callback<
protos.google.cloud.asset.v1.IFeed,
Expand Down Expand Up @@ -938,7 +938,7 @@ export class AssetServiceClient {
] = this._gaxModule.routingHeader.fromParams({
'name': request.name ?? '',
});
this.initialize();
this.initialize().catch(err => {throw err});
this._log.info('deleteFeed request %j', request);
const wrappedCallback: Callback<
protos.google.protobuf.IEmpty,
Expand Down Expand Up @@ -1052,7 +1052,7 @@ export class AssetServiceClient {
] = this._gaxModule.routingHeader.fromParams({
'parent': request.parent ?? '',
});
this.initialize();
this.initialize().catch(err => {throw err});
const wrappedCallback: Callback<
LROperation<protos.google.cloud.asset.v1.IExportAssetsResponse, protos.google.cloud.asset.v1.IExportAssetsRequest>,
protos.google.longrunning.IOperation|null|undefined,
Expand Down
68 changes: 34 additions & 34 deletions baselines/asset-esm/esm/test/gapic_asset_service_v1.ts.baseline
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ describe('v1.AssetServiceClient', () => {
credentials: {client_email: 'bogus', private_key: 'bogus'},
projectId: 'bogus',
});
client.initialize();
client.initialize().catch(err => {throw err});
assert(client.assetServiceStub);
client.close().then(() => {
done();
Expand Down Expand Up @@ -243,7 +243,7 @@ describe('v1.AssetServiceClient', () => {
credentials: {client_email: 'bogus', private_key: 'bogus'},
projectId: 'bogus',
});
client.initialize();
await client.initialize();
const request = generateSampleMessage(
new protos.google.cloud.asset.v1.BatchGetAssetsHistoryRequest()
);
Expand All @@ -270,7 +270,7 @@ describe('v1.AssetServiceClient', () => {
credentials: {client_email: 'bogus', private_key: 'bogus'},
projectId: 'bogus',
});
client.initialize();
await client.initialize();
const request = generateSampleMessage(
new protos.google.cloud.asset.v1.BatchGetAssetsHistoryRequest()
);
Expand Down Expand Up @@ -308,7 +308,7 @@ describe('v1.AssetServiceClient', () => {
credentials: {client_email: 'bogus', private_key: 'bogus'},
projectId: 'bogus',
});
client.initialize();
await client.initialize();
const request = generateSampleMessage(
new protos.google.cloud.asset.v1.BatchGetAssetsHistoryRequest()
);
Expand All @@ -332,7 +332,7 @@ describe('v1.AssetServiceClient', () => {
credentials: {client_email: 'bogus', private_key: 'bogus'},
projectId: 'bogus',
});
client.initialize();
await client.initialize();
const request = generateSampleMessage(
new protos.google.cloud.asset.v1.BatchGetAssetsHistoryRequest()
);
Expand All @@ -351,7 +351,7 @@ describe('v1.AssetServiceClient', () => {
credentials: {client_email: 'bogus', private_key: 'bogus'},
projectId: 'bogus',
});
client.initialize();
await client.initialize();
const request = generateSampleMessage(
new protos.google.cloud.asset.v1.CreateFeedRequest()
);
Expand All @@ -378,7 +378,7 @@ describe('v1.AssetServiceClient', () => {
credentials: {client_email: 'bogus', private_key: 'bogus'},
projectId: 'bogus',
});
client.initialize();
await client.initialize();
const request = generateSampleMessage(
new protos.google.cloud.asset.v1.CreateFeedRequest()
);
Expand Down Expand Up @@ -416,7 +416,7 @@ describe('v1.AssetServiceClient', () => {
credentials: {client_email: 'bogus', private_key: 'bogus'},
projectId: 'bogus',
});
client.initialize();
await client.initialize();
const request = generateSampleMessage(
new protos.google.cloud.asset.v1.CreateFeedRequest()
);
Expand All @@ -440,7 +440,7 @@ describe('v1.AssetServiceClient', () => {
credentials: {client_email: 'bogus', private_key: 'bogus'},
projectId: 'bogus',
});
client.initialize();
await client.initialize();
const request = generateSampleMessage(
new protos.google.cloud.asset.v1.CreateFeedRequest()
);
Expand All @@ -459,7 +459,7 @@ describe('v1.AssetServiceClient', () => {
credentials: {client_email: 'bogus', private_key: 'bogus'},
projectId: 'bogus',
});
client.initialize();
await client.initialize();
const request = generateSampleMessage(
new protos.google.cloud.asset.v1.GetFeedRequest()
);
Expand All @@ -486,7 +486,7 @@ describe('v1.AssetServiceClient', () => {
credentials: {client_email: 'bogus', private_key: 'bogus'},
projectId: 'bogus',
});
client.initialize();
await client.initialize();
const request = generateSampleMessage(
new protos.google.cloud.asset.v1.GetFeedRequest()
);
Expand Down Expand Up @@ -524,7 +524,7 @@ describe('v1.AssetServiceClient', () => {
credentials: {client_email: 'bogus', private_key: 'bogus'},
projectId: 'bogus',
});
client.initialize();
await client.initialize();
const request = generateSampleMessage(
new protos.google.cloud.asset.v1.GetFeedRequest()
);
Expand All @@ -548,7 +548,7 @@ describe('v1.AssetServiceClient', () => {
credentials: {client_email: 'bogus', private_key: 'bogus'},
projectId: 'bogus',
});
client.initialize();
await client.initialize();
const request = generateSampleMessage(
new protos.google.cloud.asset.v1.GetFeedRequest()
);
Expand All @@ -567,7 +567,7 @@ describe('v1.AssetServiceClient', () => {
credentials: {client_email: 'bogus', private_key: 'bogus'},
projectId: 'bogus',
});
client.initialize();
await client.initialize();
const request = generateSampleMessage(
new protos.google.cloud.asset.v1.ListFeedsRequest()
);
Expand All @@ -594,7 +594,7 @@ describe('v1.AssetServiceClient', () => {
credentials: {client_email: 'bogus', private_key: 'bogus'},
projectId: 'bogus',
});
client.initialize();
await client.initialize();
const request = generateSampleMessage(
new protos.google.cloud.asset.v1.ListFeedsRequest()
);
Expand Down Expand Up @@ -632,7 +632,7 @@ describe('v1.AssetServiceClient', () => {
credentials: {client_email: 'bogus', private_key: 'bogus'},
projectId: 'bogus',
});
client.initialize();
await client.initialize();
const request = generateSampleMessage(
new protos.google.cloud.asset.v1.ListFeedsRequest()
);
Expand All @@ -656,7 +656,7 @@ describe('v1.AssetServiceClient', () => {
credentials: {client_email: 'bogus', private_key: 'bogus'},
projectId: 'bogus',
});
client.initialize();
await client.initialize();
const request = generateSampleMessage(
new protos.google.cloud.asset.v1.ListFeedsRequest()
);
Expand All @@ -675,7 +675,7 @@ describe('v1.AssetServiceClient', () => {
credentials: {client_email: 'bogus', private_key: 'bogus'},
projectId: 'bogus',
});
client.initialize();
await client.initialize();
const request = generateSampleMessage(
new protos.google.cloud.asset.v1.UpdateFeedRequest()
);
Expand Down Expand Up @@ -703,7 +703,7 @@ describe('v1.AssetServiceClient', () => {
credentials: {client_email: 'bogus', private_key: 'bogus'},
projectId: 'bogus',
});
client.initialize();
await client.initialize();
const request = generateSampleMessage(
new protos.google.cloud.asset.v1.UpdateFeedRequest()
);
Expand Down Expand Up @@ -742,7 +742,7 @@ describe('v1.AssetServiceClient', () => {
credentials: {client_email: 'bogus', private_key: 'bogus'},
projectId: 'bogus',
});
client.initialize();
await client.initialize();
const request = generateSampleMessage(
new protos.google.cloud.asset.v1.UpdateFeedRequest()
);
Expand All @@ -767,7 +767,7 @@ describe('v1.AssetServiceClient', () => {
credentials: {client_email: 'bogus', private_key: 'bogus'},
projectId: 'bogus',
});
client.initialize();
await client.initialize();
const request = generateSampleMessage(
new protos.google.cloud.asset.v1.UpdateFeedRequest()
);
Expand All @@ -787,7 +787,7 @@ describe('v1.AssetServiceClient', () => {
credentials: {client_email: 'bogus', private_key: 'bogus'},
projectId: 'bogus',
});
client.initialize();
await client.initialize();
const request = generateSampleMessage(
new protos.google.cloud.asset.v1.DeleteFeedRequest()
);
Expand All @@ -814,7 +814,7 @@ describe('v1.AssetServiceClient', () => {
credentials: {client_email: 'bogus', private_key: 'bogus'},
projectId: 'bogus',
});
client.initialize();
await client.initialize();
const request = generateSampleMessage(
new protos.google.cloud.asset.v1.DeleteFeedRequest()
);
Expand Down Expand Up @@ -852,7 +852,7 @@ describe('v1.AssetServiceClient', () => {
credentials: {client_email: 'bogus', private_key: 'bogus'},
projectId: 'bogus',
});
client.initialize();
await client.initialize();
const request = generateSampleMessage(
new protos.google.cloud.asset.v1.DeleteFeedRequest()
);
Expand All @@ -876,7 +876,7 @@ describe('v1.AssetServiceClient', () => {
credentials: {client_email: 'bogus', private_key: 'bogus'},
projectId: 'bogus',
});
client.initialize();
await client.initialize();
const request = generateSampleMessage(
new protos.google.cloud.asset.v1.DeleteFeedRequest()
);
Expand All @@ -895,7 +895,7 @@ describe('v1.AssetServiceClient', () => {
credentials: {client_email: 'bogus', private_key: 'bogus'},
projectId: 'bogus',
});
client.initialize();
await client.initialize();
const request = generateSampleMessage(
new protos.google.cloud.asset.v1.ExportAssetsRequest()
);
Expand Down Expand Up @@ -923,7 +923,7 @@ describe('v1.AssetServiceClient', () => {
credentials: {client_email: 'bogus', private_key: 'bogus'},
projectId: 'bogus',
});
client.initialize();
await client.initialize();
const request = generateSampleMessage(
new protos.google.cloud.asset.v1.ExportAssetsRequest()
);
Expand Down Expand Up @@ -964,7 +964,7 @@ describe('v1.AssetServiceClient', () => {
credentials: {client_email: 'bogus', private_key: 'bogus'},
projectId: 'bogus',
});
client.initialize();
await client.initialize();
const request = generateSampleMessage(
new protos.google.cloud.asset.v1.ExportAssetsRequest()
);
Expand All @@ -988,7 +988,7 @@ describe('v1.AssetServiceClient', () => {
credentials: {client_email: 'bogus', private_key: 'bogus'},
projectId: 'bogus',
});
client.initialize();
await client.initialize();
const request = generateSampleMessage(
new protos.google.cloud.asset.v1.ExportAssetsRequest()
);
Expand All @@ -1013,7 +1013,7 @@ describe('v1.AssetServiceClient', () => {
credentials: {client_email: 'bogus', private_key: 'bogus'},
projectId: 'bogus',
});
client.initialize();
await client.initialize();
const expectedResponse = generateSampleMessage(
new operationsProtos.google.longrunning.Operation()
);
Expand All @@ -1033,7 +1033,7 @@ describe('v1.AssetServiceClient', () => {
credentials: {client_email: 'bogus', private_key: 'bogus'},
projectId: 'bogus',
});
client.initialize();
await client.initialize();
const expectedError = new Error('expected');

client.operationsClient.getOperation = stubSimpleCall(undefined, expectedError);
Expand All @@ -1055,7 +1055,7 @@ describe('v1.AssetServiceClient', () => {
credentials: {client_email: 'bogus', private_key: 'bogus'},
projectId: 'bogus',
});
client.initialize();
client.initialize().catch(err => {throw err});
client.pathTemplates.folderFeedPathTemplate.render =
sinon.stub().returns(fakePath);
client.pathTemplates.folderFeedPathTemplate.match =
Expand Down Expand Up @@ -1093,7 +1093,7 @@ describe('v1.AssetServiceClient', () => {
credentials: {client_email: 'bogus', private_key: 'bogus'},
projectId: 'bogus',
});
client.initialize();
client.initialize().catch(err => {throw err});
client.pathTemplates.organizationFeedPathTemplate.render =
sinon.stub().returns(fakePath);
client.pathTemplates.organizationFeedPathTemplate.match =
Expand Down Expand Up @@ -1131,7 +1131,7 @@ describe('v1.AssetServiceClient', () => {
credentials: {client_email: 'bogus', private_key: 'bogus'},
projectId: 'bogus',
});
client.initialize();
client.initialize().catch(err => {throw err});
client.pathTemplates.projectFeedPathTemplate.render =
sinon.stub().returns(fakePath);
client.pathTemplates.projectFeedPathTemplate.match =
Expand Down
1 change: 1 addition & 0 deletions baselines/asset-esm/tsconfig.json.baseline
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
"esm/src/**/*.ts",
"esm/test/*.ts",
"esm/test/**/*.ts",
"esm/src/**/*.json",
"esm/system-test/*.ts",
"esm/src/*.cjs"
]
Expand Down
Loading