This repository was archived by the owner on Jan 18, 2026. It is now read-only.
Conversation
Contributor
Author
danieljbruce
approved these changes
Mar 18, 2025
Contributor
danieljbruce
left a comment
danieljbruce
left a comment
There was a problem hiding this comment.
Looks fine to me.
The only line that concerned me was opting out of gax retries at:
https://github.com/googleapis/gapic-generator-typescript/pull/1697/files#diff-d1e77a3ac48fccec73f27d57cdef9c62f6cd7173640fa6159e7d00da6bc57c6aR618
But it should be good to go if this is really just a red herring.
Contributor
|
The link I posted doesn't work. I mean the line that says this:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue with Node 18 that linting has been blocked due to un-awaited promises. This should fix it.