Skip to content

fix: rename __init__.py to __init__.py.j2 #550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
software-dov merged 1 commit into from
Jul 23, 2020
Merged

fix: rename __init__.py to __init__.py.j2 #550

software-dov merged 1 commit into from
Jul 23, 2020

Conversation

@busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented Jul 23, 2020

Partially addresses #437

gapic-generator-python/gapic/generator/generator.py

Lines 91 to 95 in 86fd1ac

for template_name in client_templates:
# Sanity check: Skip "private" templates.
filename = template_name.split("/")[-1]
if filename.startswith("_") and filename != "__init__.py.j2":
continue

@busunkim96
fix: rename __init__.py to __init__.py.j2
de9b4a4 
Otherwise this file is excluded from generation. Partially addresses #437
@busunkim96 busunkim96 requested a review from software-dov July 23, 2020 18:34
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 23, 2020
@codecov
Copy link

codecov bot commented Jul 23, 2020 •
edited
Loading

Codecov Report

Merging #550 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #550   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines         1508      1508           
  Branches       308       308           
=========================================
  Hits          1508      1508

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a3d065...de9b4a4. Read the comment docs.

@software-dov software-dov merged commit 71a7062 into master Jul 23, 2020
@busunkim96 busunkim96 mentioned this pull request Sep 29, 2020
Closed
@busunkim96 busunkim96 deleted the busunkim96-patch-4 branch January 21, 2021 16:30
This was referenced Jan 18, 2022
Merged
Closed
This was referenced Jan 26, 2022
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@software-dov software-dov software-dov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@busunkim96 @software-dov