Skip to content

test: add routing parameter and empty call test for REST #2165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
parthea merged 11 commits into from
Oct 9, 2024
Merged

test: add routing parameter and empty call test for REST #2165

parthea merged 11 commits into from
Oct 9, 2024

Conversation

@parthea
Copy link
Contributor

@parthea parthea commented Sep 16, 2024 •
edited
Loading

This PR adds routing parameter tests for REST transport

This PR depends on #2133 and #2131. Please review those PRs first.

Fixes #2159
Closes b/364925979

@product-auto-label product-auto-label bot added the size: xl Pull request size is extra large. label Sep 16, 2024
@parthea parthea changed the title test: add routing parameter test for REST test: add routing parameter and empty call test for REST Sep 16, 2024
Base automatically changed from refactor-routing-parameters-test to main September 18, 2024 16:21
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: xl Pull request size is extra large. labels Oct 9, 2024
@parthea parthea force-pushed the refactor-routing-parameters-test-rest branch from 4189ada to 8e3f9de Compare October 9, 2024 16:38
@parthea parthea marked this pull request as ready for review October 9, 2024 16:38
@parthea parthea requested a review from a team as a code owner October 9, 2024 16:38
@parthea parthea closed this Oct 9, 2024
@parthea parthea deleted the refactor-routing-parameters-test-rest branch October 9, 2024 16:39
@parthea parthea restored the refactor-routing-parameters-test-rest branch October 9, 2024 16:40
@parthea parthea reopened this Oct 9, 2024
@parthea parthea force-pushed the refactor-routing-parameters-test-rest branch from 8e3f9de to 6a128b5 Compare October 9, 2024 16:43
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: m Pull request size is medium. labels Oct 9, 2024
ohmayr
ohmayr reviewed Oct 9, 2024
View reviewed changes
ohmayr
ohmayr reviewed Oct 9, 2024
View reviewed changes
ohmayr
ohmayr reviewed Oct 9, 2024
View reviewed changes
@ohmayr
Copy link
Contributor

ohmayr commented Oct 9, 2024

We may want to clean this up: https://github.com/googleapis/gapic-generator-python/pull/2165/files#diff-0f64a5dcd8e2f3ac9b10417f899604726f8111968a1b5e46b6339c39df071af0R2813-R2815.

@parthea parthea enabled auto-merge (squash) October 9, 2024 18:12
@parthea parthea merged commit da684d5 into main Oct 9, 2024
@parthea parthea deleted the refactor-routing-parameters-test-rest branch October 9, 2024 18:19
gkevinzheng pushed a commit that referenced this pull request Oct 22, 2024
@parthea @gkevinzheng
test: add routing parameter and empty call test for REST (#2165)
b30ee6a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ohmayr ohmayr ohmayr approved these changes

Assignees

@vchudnov-g vchudnov-g

Labels

size: xl Pull request size is extra large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update the empty_call_test and routing_parameter_test macro so that it can be used for both gRPC and REST

3 participants

@parthea @ohmayr @vchudnov-g