Skip to content

test: add showcase to goldens files #1991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
parthea wants to merge 3 commits into from
Closed

test: add showcase to goldens files #1991

parthea wants to merge 3 commits into from

Conversation

@parthea
Copy link
Contributor

@parthea parthea commented Mar 21, 2024 •
edited
Loading

This PR

Wait for googleapis/gapic-showcase#1477

@product-auto-label product-auto-label bot added the size: xl Pull request size is extra large. label Mar 21, 2024
@parthea parthea mentioned this pull request Mar 21, 2024
Merged
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 21, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 21, 2024
parthea
parthea commented Mar 21, 2024
View reviewed changes
@parthea parthea added do not merge Indicates a pull request not ready for merge, due to either quality or timing. owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 21, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 21, 2024
@parthea parthea mentioned this pull request Mar 21, 2024
Merged
@parthea parthea removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 21, 2024
@vchudnov-g vchudnov-g added the priority: p2 Moderately-important priority. Fix may not be included in next release. label Mar 21, 2024
@parthea
Copy link
Contributor Author

parthea commented Mar 21, 2024 •
edited
Loading

The failure in Tests / integration is captured in #1993

@parthea parthea added the status: blocked Resolving the issue is dependent on other work. label Mar 21, 2024
@parthea parthea closed this Apr 12, 2024
@parthea parthea mentioned this pull request May 2, 2024
Open
@parthea parthea mentioned this pull request Sep 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@parthea parthea

Labels

priority: p2 Moderately-important priority. Fix may not be included in next release. size: xl Pull request size is extra large. status: blocked Resolving the issue is dependent on other work.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@parthea @vchudnov-g