fix: Resolve errors from annotating containers with non-local enums #1608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reproduces the issue in # googleapis#1607
The key was `from __future__ import annotations`, which implements PEP 563 (which is planned for inclusion in Python 3.11)
atulep
approved these changes
Feb 23, 2023
Mariatta
reviewed
Feb 23, 2023
| @@ -0,0 +1,50 @@ | |||
| // Copyright 2021 Google LLC | |||
There was a problem hiding this comment.
Suggested change
| // Copyright 2021 Google LLC | |
| // Copyright 2023 Google LLC |
vchudnov-g
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The key was
from __future__ import annotations, implementing PEP563, which, though approved in 2017, is now planned for inclusion in Python 3.11 (see this Reddit discussion and Python.org discussion).
Fixes #1607.