-
Notifications
You must be signed in to change notification settings - Fork 74
fix: disambiguate field headers whose names are reserved python words #1178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f9d2911 to
7fd8460
Compare
|
The integration test is failing with It may be related to pypa/setuptools#3071 and pypa/setuptools#3061 The stack trace is similar |
|
This is ready for review. I've confirmed that the unit tests pass locally in the generated client for |
software-dov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a personal preference nit.
vam-google
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Just curious, why mark this PR as |
|
@software-dov I added |
Fixes #1177