fix: Fix rest transport logic #1039
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes 1) Do not include asyncio tests in the generated tests, because rest transport does not have asynio client. 2) Generate body field mock values for generated tests (otherwise grpc transcodding logic would fail). 3) Make `always_use_jwt_access=True` default for rest clients (grpc already does that) to match expected calls in generated tests. 4) Fix mypy errors for `AuthorizedSession` by ignoring it 5) Include operations_v1 conditionally, only if the client has lro There are few more fixes left, which are expected to be fixed in separate PRs. 1) `message->to_dict->message` roundrtip problem for int64 types is expected to be fixed by googleapis/proto-plus-python#267 2) builtins conflicts (`license_` vs `license` as field name) is expected to be fixed by a TBD PR
google-cla
bot
added
the
cla: yes
kbandes
approved these changes
Oct 25, 2021
atulep
approved these changes
Oct 25, 2021
busunkim96
approved these changes
Oct 25, 2021
This was referenced Jan 18, 2022
This was referenced Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes
always_use_jwt_access=Truedefault for rest clients (grpc already does that) to match expected calls in generated tests.AuthorizedSessionby ignoring itThere are few more fixes left, which are expected to be fixed in separate PRs:
message->to_dict->messageroundrtip problem for int64 types is expected to be fixed by fix: setting 64bit fields from strings supported proto-plus-python#267license_vslicenseas field name) is expected to be fixed by a TBD PR