-
Notifications
You must be signed in to change notification settings - Fork 74
Closed
Labels
priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Description
See https://github.com/googleapis/python-firestore/pull/197/files/ for an example.
The exceptions do not seem to get consistently sorted in alphabetical order.
The fluctuating order shows up in the three files with this clause.
Lines 91 to 97 in b2e5274
| predicate=retries.if_exception_type( | |
| {%- filter sort_lines %} | |
| {%- for ex in method.retry.retryable_exceptions %} | |
| exceptions.{{ ex.__name__ }}, | |
| {%- endfor %} | |
| {%- endfilter %} | |
| ), |
Metadata
Metadata
Assignees
Labels
priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.