Skip to content

Order of exceptions in retries.if_exception_type is unstable #617

@busunkim96

Description

@busunkim96

See https://github.com/googleapis/python-firestore/pull/197/files/ for an example.

The exceptions do not seem to get consistently sorted in alphabetical order.

The fluctuating order shows up in the three files with this clause.

predicate=retries.if_exception_type(
{%- filter sort_lines %}
{%- for ex in method.retry.retryable_exceptions %}
exceptions.{{ ex.__name__ }},
{%- endfor %}
{%- endfilter %}
),

Metadata

Metadata

Assignees

Labels

priority: p2Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions