-
Notifications
You must be signed in to change notification settings - Fork 74
Closed
Labels
priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.‘Nice-to-have’ improvement, new feature or different behavior or design.
Description
The gapic generator automatically attaches routing metadata based on the protos, by appending the x-goog-request-params to whatever metadata the user passes in. But sometimes users may want to customize the x-goog-request-params field itself. In bigtable, we need to customize the field based on some values set in the veneer layer
To solve this, I propose we add a check to ensure we are only setting x-goog-request-params when it doesn't exist in the passed in metadata, to avoid adding a duplicate field. But let me know if you have other thoughts
Related bigtable bug: googleapis/python-bigtable#1004
Metadata
Metadata
Assignees
Labels
priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.‘Nice-to-have’ improvement, new feature or different behavior or design.