Skip to content
This repository was archived by the owner on Mar 26, 2026. It is now read-only.
This repository was archived by the owner on Mar 26, 2026. It is now read-only.

Type field mistakenly called as type_ in generated unit tests #1359

Closed
Closed
Type field mistakenly called as type_ in generated unit tests#1359
Labels
priority: p2Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.
@vam-google

Description

@vam-google
vam-google
opened on Jul 20, 2022

When generating logging python client (https://github.com/googleapis/googleapis/blob/master/google/logging/v2/BUILD.bazel#L191), the generated unit tests fails with:

            response = await client.write_log_entries(
                log_name='log_name_value',
>               resource=monitored_resource_pb2.MonitoredResource(type_='type__value'),
                labels={'key_value': 'value_value'},
                entries=[log_entry.LogEntry(log_name='log_name_value')],
            )
E           ValueError: Protocol message MonitoredResource has no "type_" field.

This is currently being fixed by owlbot.py post-processing logic https://github.com/googleapis/python-logging/blob/main/owlbot.py#L29 but should be fixed in the generator itself

Metadata

Metadata

Assignees

No one assigned

    Labels

    priority: p2Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions