Skip to content

Naming conflict with create_channel in 2 generated clients #1149

@parthea

Description

@parthea

Unit tests are failing in the generated client for google/cloud/video/livestream/v1 here.

Steps to reproduce

  • clone googleapis-gen and cd in to the directory google/cloud/video/livestream/v1/video-livestream-v1-py
  • run the python post processor image in the root of google/cloud/video/livestream/v1/video-livestream-v1-py using
docker run --user $(id -u):$(id -g) --rm -v $(pwd):/repo -w /repo gcr.io/cloud-devrel-public-resources/owlbot-python:latest
  • run unit tests for python 3.8 with nox -s unit-3.8
  • The majority of tests fail with 'property' object is not callable

See stacktrace in screenshot below.

create_channel appears in the same class as both a property and a method. I believe this is due to the fact that there is an rpc with the name CreateChannel here which is converted to snake case as create_channel.

Screen Shot 2022-01-24 at 7 35 18 AM

Metadata

Metadata

Labels

🚨This issue needs some love.priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions