This repository was archived by the owner on Jul 13, 2025. It is now read-only.
deprecate resource names not supported by microgenerators#3016
Merged
yihanzhen merged 8 commits intogoogleapis:masterfrom Nov 7, 2019
Merged
deprecate resource names not supported by microgenerators#3016yihanzhen merged 8 commits intogoogleapis:masterfrom
yihanzhen merged 8 commits intogoogleapis:masterfrom
Conversation
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #3016 +/- ##
============================================
+ Coverage 87.09% 87.09% +<.01%
+ Complexity 5949 5946 -3
============================================
Files 491 490 -1
Lines 23681 23678 -3
Branches 2547 2546 -1
============================================
- Hits 20625 20623 -2
+ Misses 2210 2209 -1
Partials 846 846
Continue to review full report at Codecov.
|
Contributor
|
Python generated warnings look good. |
yihanzhen
requested review from
alexander-fenster,
busunkim96,
dazuma,
software-dov and
vam-google
Contributor
Author
|
@vam-google for implementation review. |
busunkim96
approved these changes
Nov 4, 2019
yihanzhen
changed the title
Contributor
Author
|
Hi @vam-google @dazuma |
dazuma
reviewed
Nov 6, 2019
| @# @@return [String] | ||
| def self.{@function.name} {@createResourceFunctionParams(function.resourceIdParams)} | ||
| @if function.isResourceNameDeprecated | ||
| warn "This helper function will be deleted in the next major version." |
Contributor
There was a problem hiding this comment.
Please omit this. Ruby devs do not like warnings printed to stderr with no way of disabling it.
Contributor
Author
|
PTAL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecate resource names that will not exist in microgenerator/proto annotation world.
add a
deprecated_collectionsfield in gapic config V2. Resource names specified here will continue to be generated the same way gapic generator treatscollectionsin gapic config v1, but the helper functions will be marked deprecated.Add two deprecated resource names in baseline tests,
project_bookto test the case where a deprecated resource name has the same name as a non-deprecated one, andbook_from_archiveto test the case where a deprecated resource has a unique name.Node.js change: add a deprecation warning to all resource name helpers related to
project_bookandbook_from_archive===> PTAL @alexander-fensterRuby: add a deprecation warning to all resource name helpers related to
book_from_archiveandproject_book===> PTAL @dazumaPython: add a deprecation warning to all resource names. ===> PTAL @software-dov @busunkim96 (Fix Python: Deprecate resource name helper functions #3012)