This repository was archived by the owner on Jul 13, 2025. It is now read-only.
Add SERVICE_ADDRESS to generated resource names toString()#2529
Merged
andreamlin merged 1 commit intogoogleapis:masterfrom Jan 29, 2019
Merged
Add SERVICE_ADDRESS to generated resource names toString()#2529andreamlin merged 1 commit intogoogleapis:masterfrom
andreamlin merged 1 commit intogoogleapis:masterfrom
Conversation
Contributor
Author
|
PTAL |
Codecov Report
@@ Coverage Diff @@
## master #2529 +/- ##
============================================
- Coverage 86.72% 86.71% -0.01%
+ Complexity 5420 5419 -1
============================================
Files 461 461
Lines 21411 21411
Branches 2348 2348
============================================
- Hits 18568 18567 -1
Misses 1998 1998
- Partials 845 846 +1
Continue to review full report at Codecov.
|
yihanzhen
approved these changes
Jan 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes googleapis/google-cloud-java#4416.