Rename Rakefile tasks#1671
Conversation
\googleapis#1660 renamed some tasks to introduce `ci:acceptance`, but in the wrong place. The acceptance task should be runnable in all cases, even when there are no smoke tests.
|
Should this also make the generated smoke tests run on |
|
@landrito Isn't that already the case with the task defined here: https://github.com/googleapis/toolkit/pull/1671/files#diff-fdaf77e823c0b9f1416f7386beb45fc2R60 |
|
Blah, brain fart. LGTM |
|
Oh wait, I retract my LGTM. I mean to say these two tasks should be merged. |
Also rename parameterized toolkit tests for sanity.
|
@landrito I don't know about merged, but I made smoke tests are a subset of acceptance. (Especially with partial GAPICs, we might expect that there are manual, non-smoke test acceptance tests that you might want to be able to invoke separately.) |
|
Hm. Okay. I think I buy that a distinction is still needed. |
Not all tests involve "library"
Codecov Report
@@ Coverage Diff @@
## master #1671 +/- ##
=========================================
Coverage 85.52% 85.52%
Complexity 4290 4290
=========================================
Files 405 405
Lines 16863 16863
Branches 1760 1760
=========================================
Hits 14422 14422
Misses 1854 1854
Partials 587 587Continue to review full report at Codecov.
|
3 participants
#1660 renamed some tasks to introduce
ci:acceptance, but in the wrongplace. The acceptance task should be runnable in all cases, even when
there are no smoke tests.