This repository was archived by the owner on Jul 13, 2025. It is now read-only.
Add bogus credentials in Node.js unit tests.#1628
Merged
landrito merged 1 commit intogoogleapis:masterfrom Oct 17, 2017
Merged
Conversation
This was referenced Oct 17, 2017
Codecov Report
@@ Coverage Diff @@
## master #1628 +/- ##
=========================================
Coverage 85.52% 85.52%
Complexity 4784 4784
=========================================
Files 458 458
Lines 19169 19169
Branches 2060 2060
=========================================
Hits 16395 16395
Misses 2145 2145
Partials 629 629Continue to review full report at Codecov.
|
landrito
approved these changes
Oct 17, 2017
Contributor
landrito
left a comment
landrito
left a comment
There was a problem hiding this comment.
LGTM, Small unnecessary nit would be to move these bogus credentials into a const.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This stops the promise rejections (click in to the actual test run to see them) in environments without ADC.