This repository was archived by the owner on Jul 13, 2025. It is now read-only.
Java: migrating off deprecated methods#1197
Merged
garrettjonesgoogle merged 1 commit intogoogleapis:masterfrom Apr 19, 2017
Merged
Java: migrating off deprecated methods#1197garrettjonesgoogle merged 1 commit intogoogleapis:masterfrom
garrettjonesgoogle merged 1 commit intogoogleapis:masterfrom
Conversation
This was referenced Apr 19, 2017
Codecov Report
@@ Coverage Diff @@
## master #1197 +/- ##
===========================================
+ Coverage 86% 86% +<.01%
- Complexity 3678 3682 +4
===========================================
Files 372 372
Lines 14583 14588 +5
Branches 1626 1627 +1
===========================================
+ Hits 12542 12547 +5
Misses 1606 1606
Partials 435 435
Continue to review full report at Codecov.
|
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Yes,
getIndexMapMaplooks funny, but that's because the name of the field itself ends in "map". It turns out that proto generates bothget${FieldName}andget${FieldName}Map, and the first one is@Deprecated.This PR coordinates with upcoming PRs in gax-java & google-cloud-java.