Skip to content
This repository was archived by the owner on Jul 13, 2025. It is now read-only.

Update generated page response#1139

Merged
michaelbausor merged 11 commits intogoogleapis:masterfrom
michaelbausor:update-page
Apr 11, 2017
Merged

Update generated page response#1139
michaelbausor merged 11 commits intogoogleapis:masterfrom
michaelbausor:update-page

Conversation

@michaelbausor
Copy link
Copy Markdown
Contributor

@michaelbausor michaelbausor commented Mar 28, 2017

Work in progress, wanted to get feedback on the approach. Each generated paged response object and page object has a lot more methods that before, but the implementations are very simple, with as much work as possible being delegated to the context object.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 28, 2017 •
edited
Loading

Codecov Report

Merging #1139 into master will increase coverage by <.01%.
The diff coverage is 87.87%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1139      +/-   ##
============================================
+ Coverage     86.09%   86.09%   +<.01%     
- Complexity     3618     3687      +69     
============================================
  Files           364      372       +8     
  Lines         14264    14544     +280     
  Branches       1589     1626      +37     
============================================
+ Hits          12280    12522     +242     
- Misses         1552     1585      +33     
- Partials        432      437       +5
Impacted Files Coverage Δ Complexity Δ
...codegen/viewmodel/StaticLangPagedResponseView.java 100% <ø> (ø) 2 <0> (ø) ⬇️
...egen/viewmodel/PagedResponseIterateMethodView.java 100% <ø> (ø) 2 <0> (ø) ⬇️
.../transformer/java/JavaGapicSurfaceTransformer.java 98.87% <100%> (+0.08%) 43 <1> (ø) ⬇️
...api/codegen/transformer/java/JavaSurfaceNamer.java 83.92% <100%> (-2.61%) 28 <3> (+3)
...m/google/api/codegen/transformer/SurfaceNamer.java 78.74% <42.85%> (-1.26%) 170 <2> (+1)
...codegen/grpcmetadatagen/GrpcMetadataGenerator.java 64% <0%> (-14.34%) 3% <0%> (-5%)
.../com/google/api/codegen/py/PythonGapicContext.java 75.6% <0%> (-12.58%) 51% <0%> (-16%)
...main/java/com/google/api/codegen/LanguageUtil.java 31.57% <0%> (-5.27%) 4% <0%> (-1%)
...oogle/api/codegen/util/py/PythonNameFormatter.java 72.72% <0%> (-4.55%) 12% <0%> (-1%)
... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e87db39...cb4cb7e. Read the comment docs.

garrettjonesgoogle
garrettjonesgoogle reviewed Mar 28, 2017
View reviewed changes
Comment thread src/test/java/com/google/api/codegen/testdata/java_page_streaming_response_library.baseline Outdated
public static class ListShelvesPagedResponse extends PagedListResponseImpl<ListShelvesRequest, ListShelvesResponse, Shelf> {
public static class ListShelvesPagedResponse implements PagedListResponse<Shelf> {

private final PagedListResponseContext<RequestT, ResponseT, ResourceT> context;

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread src/test/java/com/google/api/codegen/testdata/java_page_streaming_response_library.baseline Outdated
}
}

public Object getNextPageToken() {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@michaelbausor michaelbausor mentioned this pull request Mar 28, 2017
Merged
garrettjonesgoogle
garrettjonesgoogle reviewed Apr 10, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@garrettjonesgoogle garrettjonesgoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after the name issue is fixed, and after you verify tests pass in api-client-staging after regenerating there.

Comment thread src/main/java/com/google/api/codegen/viewmodel/StaticLangPagedResponseView.java Outdated

public abstract String name();

public abstract String pageName();

This comment was marked as spam.

Sign in to view

@garrettjonesgoogle
Copy link
Copy Markdown
Contributor

garrettjonesgoogle commented Apr 10, 2017

Thanks for catching more that I didn't notice - LGTM

@michaelbausor michaelbausor changed the title WIP: Update generated page response Update generated page response Apr 11, 2017
@michaelbausor michaelbausor merged commit 825567c into googleapis:master Apr 11, 2017
@michaelbausor michaelbausor deleted the update-page branch April 11, 2017 20:24
@michaelbausor michaelbausor mentioned this pull request Apr 12, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@garrettjonesgoogle garrettjonesgoogle garrettjonesgoogle left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@michaelbausor @codecov-io @garrettjonesgoogle