Skip to content
This repository was archived by the owner on Jul 13, 2025. It is now read-only.
This repository was archived by the owner on Jul 13, 2025. It is now read-only.

[Node] Pub Sub has manually written method in generated code #2127

@crwilcox

Description

@crwilcox

While generaing in the nodejs-pubsub package I found this code getting removed in src/v1/subscriber_client.js since it was added manually. Is this code the generator should have inserted?

    // note: editing generated code
    this.waitForReady = function(deadline, callback) {
      return subscriberStub.then(
        stub => stub.waitForReady(deadline, callback),
        callback
      );
    };

Metadata

Metadata

Labels

🚨This issue needs some love.lang: nodejsIssues specific to JavaScript or TypeScript.priority: p2Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.yoshi

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions