Conversation
google-cla
Bot
added
the
cla: yes
tmatsuo
approved these changes
Sep 28, 2020
gcf-merge-on-green Bot
pushed a commit
to googleapis/google-cloud-go
that referenced
this pull request
Sep 29, 2020
I also changed the return type of parse to be a result type to simplify passing the... results around. Related to googleapis/doc-pipeline#39.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds markdown files to the input for the DocFX generator, which makes it so we can incorporate markdown files from client libraries.
We may need style/formatting changes in the future, but this is a good start.