Skip to content

Regenerate compute_gapic.yaml#91

Merged
andreamlin merged 1 commit intogoogleapis:masterfrom
andreamlin:compute_gapic_config
Sep 5, 2018
Merged

Regenerate compute_gapic.yaml#91
andreamlin merged 1 commit intogoogleapis:masterfrom
andreamlin:compute_gapic_config

Conversation

@andreamlin
Copy link
Copy Markdown
Contributor

@andreamlin andreamlin commented Sep 5, 2018

We need to regenerate the gapic config for compute in order to refresh the library itself, because the gapic config defines new resource types and methods that were introduced in the compute Discovery doc.

@andreamlin
Copy link
Copy Markdown
Contributor Author

PTAL
The regenerated compute library passes tests googleapis/google-cloud-java#3642

Copy link
Copy Markdown
Contributor

@yihanzhen yihanzhen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreamlin andreamlin merged commit 3ca9d5d into googleapis:master Sep 5, 2018
@andreamlin andreamlin deleted the compute_gapic_config branch September 5, 2018 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants