This repository was archived by the owner on Jan 21, 2026. It is now read-only.
fix: don't let trace context injection throw#989
Merged
kjin merged 2 commits intogoogleapis:masterfrom Apr 3, 2019
Merged
Conversation
googlebot
added
the
cla: yes
ofrobots
reviewed
Apr 2, 2019
Contributor
ofrobots
left a comment
ofrobots
left a comment
There was a problem hiding this comment.
Can we have a test for this?
Contributor
Author
|
@ofrobots Thanks for the suggestions, this PR is ready for another look. |
ofrobots
approved these changes
Apr 2, 2019
kjin
force-pushed
the
expect-more
branch
2 times, most recently
from
0e92504 to
e2fb08f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's possible for
setHeaderto throw if an outgoing request was created with a headerExpectbut not capitalized exactly that way. This change makes checking for theexpectheader a little more robust, and also swallows an error that would be thrown for further unexpected capitalizations.It's possible that
hasExpectHeadercan either (1) stay the same or (2) be even more robust and actually iterate through all header keys to do a case-insensitive check. I'm definitely OK with the first option, the second option might have too much overhead to accomadate for a rare issue.