This repository was archived by the owner on Jan 21, 2026. It is now read-only.
fix(deps): update dependency gcp-metadata to v1#975
Merged
Conversation
googlebot
added
the
cla: yes
renovate
Bot
force-pushed
the
renovate/gcp-metadata-1.x
branch
from
390cf61 to
5723e17
Compare
renovate
Bot
force-pushed
the
renovate/gcp-metadata-1.x
branch
from
5723e17 to
2802c6e
Compare
kjin
added
status: blocked
Contributor
|
Blocked by googleapis/gcp-metadata#171 |
ofrobots
removed
the
status: blocked
Contributor
|
Not blocked as googleapis/gcp-metadata#171 is closed unmerged now. |
1 task
Contributor
Author
PR has been edited👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description. |
ofrobots
reviewed
Feb 25, 2019
ofrobots
reviewed
Feb 26, 2019
| .get('/computeMetadata/v1/project/project-id') | ||
| .once() | ||
| .reply(status, reply, {'Metadata-Flavor': 'Google'}); | ||
| return nock(HOST_ADDRESS).get(HOST_ADDRESS).once().reply(status, reply, { |
Contributor
There was a problem hiding this comment.
Are the two occurrences of HOST_ADDRESS intentional?
|
|
||
| it('should not trace publishes', function(done) { | ||
| var metadataScope = nock('http://metadata.google.internal') | ||
| var metadataScope = nock('http://metadata.google.internal.') |
kjin
force-pushed
the
renovate/gcp-metadata-1.x
branch
from
e2d239e to
5f586c5
Compare
kjin
approved these changes
Feb 26, 2019
Contributor
|
TBR=@ofrobots |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
^0.9.0->^1.0.0Release Notes
googleapis/gcp-metadata
v1.0.0Compare Source
02-14-2019 16:00 PST
Bug Fixes
Documentation
Internal / Testing Changes
Renovate configuration
📅 Schedule: At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻️ Rebasing: Whenever PR is stale, or if you modify the PR title to begin with "
rebase!".🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot. View repository job log here.