This repository was archived by the owner on Jan 21, 2026. It is now read-only.
Output 'noPluginName' in trace-api log messages where pluginName is undefined#958
Merged
kjin merged 2 commits intogoogleapis:masterfrom Jan 23, 2019
Merged
Output 'noPluginName' in trace-api log messages where pluginName is undefined#958kjin merged 2 commits intogoogleapis:masterfrom
'noPluginName' in trace-api log messages where pluginName is undefined#958kjin merged 2 commits intogoogleapis:masterfrom
Conversation
… undefined This will change log messages like this from: ``` [JS] @google-cloud/trace-agent DEBUG TraceApi#createChildSpan: [undefined] Created child span [doSomething()] [JS] @google-cloud/trace-agent DEBUG TraceApi#createChildSpan: [undefined] Created child span [doSomething() -> browserStart] ``` To this: ``` [JS] @google-cloud/trace-agent DEBUG TraceApi#createChildSpan: [noPluginName] Created child span [doSomething()] [JS] @google-cloud/trace-agent DEBUG TraceApi#createChildSpan: [noPluginName] Created child span [doSomething() -> browserStart] ```
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
googlebot
added
the
cla: no
Contributor
Author
|
I signed it! Although, I did get this error when I attempted to sign it:
|
|
CLAs look good, thanks! |
googlebot
added
cla: yes
kjin
reviewed
Jan 22, 2019
Contributor
Author
|
Thank you @kjin! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will change log messages like this from:
To this: