This repository was archived by the owner on Jan 21, 2026. It is now read-only.
feat: allow users to specify a propagation mechanism#950
Closed
kjin wants to merge 3 commits intogoogleapis:masterfrom
Closed
feat: allow users to specify a propagation mechanism#950kjin wants to merge 3 commits intogoogleapis:masterfrom
kjin wants to merge 3 commits intogoogleapis:masterfrom
Conversation
googlebot
added
the
cla: yes
kjin
force-pushed
the
prop-b3
branch
4 times, most recently
from
3757724 to
bbaeef2
Compare
kjin
changed the title
Contributor
Author
|
Blocked by: census-instrumentation/opencensus-node#340 |
ofrobots
added
the
status: blocked
Contributor
|
@kjin census-instrumentation/opencensus-node#340 is done. Is this still blocked? |
Contributor
Author
|
It'll be unblocked when 0.0.10 is released. In other words, now blocked by Milestone #2 |
|
@kjin 0.0.10 has been released. Is this still blocked? |
Contributor
Author
|
@emillg Thanks for the reminder. I'll move this forward shortly |
Contributor
Author
|
I'm going to take a different approach on this... will leave the issue open so it won't get dropped. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #949
This feature allows users to supply a
Propagation(or an absolute path to a file that exports that interface) to specify how trace context headers are injected and extracted from HTTP requests. It also replaces the built-in propagation mechanism with that of@opencensus/propagation-stackdriver, which has the same behavior.Some notes:
StackdriverTracerobject doesn't have the same interface as the input object, the latter of which is modeled on OpenCensus while the former is just something I deemed to be more suitable for this module. Particularly of note is that OpenCensus treats all span IDs as length-16 hex strings, while we use decimal integer strings.Propagationobject because of the above reasons. I'm open to discussion on this.