Skip to content
This repository was archived by the owner on Jan 21, 2026. It is now read-only.

fix: #942 - use req.ip in express and koa plugin#944

Merged
kjin merged 2 commits intogoogleapis:masterfrom
sh:master
Dec 17, 2018
Merged

fix: #942 - use req.ip in express and koa plugin#944
kjin merged 2 commits intogoogleapis:masterfrom
sh:master

Conversation

@sh
Copy link
Copy Markdown
Contributor

@sh sh commented Dec 17, 2018

fix for #942 :)

@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Dec 17, 2018
@kjin kjin self-requested a review December 17, 2018 17:48
@sh
Copy link
Copy Markdown
Contributor Author

sh commented Dec 17, 2018

I signed it!

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Dec 17, 2018
Comment thread src/plugins/plugin-koa.ts Outdated
@kjin kjin merged commit 126bc75 into googleapis:master Dec 17, 2018
@SifouElYasLakhHa
Copy link
Copy Markdown

I signed it!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants