This repository was archived by the owner on Jan 21, 2026. It is now read-only.
fix: end child spans correctly in pg#930
Merged
kjin merged 3 commits intogoogleapis:masterfrom Jan 22, 2019
Merged
Conversation
googlebot
added
the
cla: yes
kjin
changed the title
ofrobots
reviewed
Dec 5, 2018
ofrobots
approved these changes
Jan 17, 2019
Contributor
ofrobots
left a comment
ofrobots
left a comment
There was a problem hiding this comment.
Rubberstamp LGTM once the tests are green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test failures in PR #913 (support child spans with tail latencies) exposes an issue with the instrumentation code for Postgres, where child spans were not being closed if a generic
Submittableis used in lieu of aQuery. This PR fixes that.