Skip to content
This repository was archived by the owner on Jan 21, 2026. It is now read-only.

feat: add contextHeaderBehavior option#900

Merged
kjin merged 3 commits intogoogleapis:masterfrom
kjin:require-context
Nov 2, 2018
Merged

feat: add contextHeaderBehavior option#900
kjin merged 3 commits intogoogleapis:masterfrom
kjin:require-context

Conversation

@kjin
Copy link
Copy Markdown
Contributor

@kjin kjin commented Oct 31, 2018

Fixes #879, but also rolls the "experimental" ignoreContextHeader option into a new contextHeaderOptions.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 31, 2018
@kjin kjin changed the title [dnr] feat: add contextHeaderBehavior option feat: add contextHeaderBehavior option Oct 31, 2018
@kjin kjin requested a review from a team October 31, 2018 22:07
Comment thread src/config.ts Outdated
/**
* Specifies how to use incoming trace context headers. The following options
* are available:
* 'default' -- Trace context headers will be respected for incoming

This comment was marked as spam.

This comment was marked as spam.

Comment thread src/config.ts
* requests that support it. A new trace will be created for requests
* without trace context headers.
* 'require' -- Same as default, but traces won't be created for requests
* without trace context headers. This should not be set for end user-facing

This comment was marked as spam.

This comment was marked as spam.

Comment thread src/config.ts Outdated
* services, as this header is usually set by other traced services rather
* than by users.
* 'ignore' -- Always ignore trace context headers, so a new trace with a
* unique ID will be created for every request.

This comment was marked as spam.

This comment was marked as spam.

@kjin kjin merged commit 199cb42 into googleapis:master Nov 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants