This repository was archived by the owner on Jan 21, 2026. It is now read-only.
fix: update @google-cloud/common dependency to 0.25.3#871
Merged
Conversation
googlebot
added
the
cla: yes
ghost
assigned
jcao219
approved these changes
Sep 27, 2018
jcao219
left a comment
jcao219
left a comment
There was a problem hiding this comment.
This update fixes an issue where google-auth-library falsely believes that it is not running in a GCE instance, when in fact it is, because the API call to retrieve the instance metadata might fail with ECONNRESET on the first try.
Contributor
|
@kjin nudges |
DominicKramer
approved these changes
Sep 27, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR upgrades @g-c/c to avoid an issue with authentication in
gcp-metadatathat was fixed in a newer version of the module.In order to make this change, I've changed and moved tests that deal with keyFilename/credentials to be more modular (it's a test of the trace writer, not the module as a whole).
Also closes #855