Skip to content
This repository was archived by the owner on Jan 21, 2026. It is now read-only.

feat: use small HTTP dependency#858

Merged
fhinkel merged 1 commit intomasterfrom
withTeeny
Sep 18, 2018
Merged

feat: use small HTTP dependency#858
fhinkel merged 1 commit intomasterfrom
withTeeny

Conversation

@fhinkel
Copy link
Copy Markdown
Contributor

@fhinkel fhinkel commented Sep 8, 2018

Use teenyRequest instead of request. This saves 900 ms at
startup time.

Improve load time from 1500 ms to 650 ms.

Before request:
screen shot 2018-09-07 at 9 27 55 pm

After with teenyRequest:
screen shot 2018-09-07 at 9 28 52 pm

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 8, 2018
@kjin
Copy link
Copy Markdown
Contributor

kjin commented Sep 13, 2018

There is a problem where teeny-request expects its body input to be an object, while request expects it to be a string. We exhibit the latter behavior currently, so this PR fails system tests. I'm currently trying to fix it.

@fhinkel
Copy link
Copy Markdown
Contributor Author

fhinkel commented Sep 14, 2018

Thanks, PRs to teeny are welcome! I had accidentally stringified a string, but fixed that in 3.8.

@fhinkel
Copy link
Copy Markdown
Contributor Author

fhinkel commented Sep 17, 2018

ping @kjin

@kjin
Copy link
Copy Markdown
Contributor

kjin commented Sep 17, 2018

@fhinkel Oh, I didn't know you were the author of teeny-request 😆 I'll open a PR if you haven't fixed that already.

Use teenyRequest instead of request. This saves 900 ms at
startup time.
@ghost ghost assigned fhinkel Sep 18, 2018
@fhinkel fhinkel merged commit 210dc3f into master Sep 18, 2018
@fhinkel fhinkel deleted the withTeeny branch September 18, 2018 01:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants