This repository was archived by the owner on Jan 21, 2026. It is now read-only.
feat: allow incoming http header to override span name#821
Closed
kjin wants to merge 3 commits intogoogleapis:masterfrom
Closed
feat: allow incoming http header to override span name#821kjin wants to merge 3 commits intogoogleapis:masterfrom
kjin wants to merge 3 commits intogoogleapis:masterfrom
Conversation
googlebot
added
the
cla: yes
ofrobots
reviewed
Jul 25, 2018
Contributor
ofrobots
left a comment
ofrobots
left a comment
There was a problem hiding this comment.
This mechanism can be abused / spammed as the headers are generally in control of clients.
Contributor
Author
|
@ofrobots I added a config option that turns this feature on. By default it is off. |
Contributor
Author
|
Closed in favor of #826. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces
Tracer#constants.TRACE_SPAN_NAME_OVERRIDEwhich, when used as a header key on an incoming request, changes the span name to the value of this header.