This repository was archived by the owner on Jan 21, 2026. It is now read-only.
fix: improve logs from the trace writer#800
Merged
kjin merged 3 commits intogoogleapis:masterfrom Jul 18, 2018
Merged
Conversation
googlebot
added
the
cla: yes
ofrobots
reviewed
Jul 16, 2018
| this.logger.error(`TraceWriter#publish: Received error ${ | ||
| statusCode ? | ||
| `with status code ${statusCode}` : | ||
| ''} while publishing traces to cloudtrace.googleapis.com: ${ |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
ofrobots
approved these changes
Jul 17, 2018
Contributor
ofrobots
left a comment
ofrobots
left a comment
There was a problem hiding this comment.
LGTM once nit is disposed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #797
This PR adds hostnames to error messages coming from the Trace Writer. It also changes one error message to not print "status code unknown" (this is misleading because unknown actually means an error was thrown when making an outgoing request).
Other errors are forwarded from the
@google-cloud/commonmodule, so any additional changes to improve error messages would need to originate there.cc/ @ahmetb