This repository was archived by the owner on Jan 21, 2026. It is now read-only.
feat: add getProjectId and getCurrentRootSpan#782
Merged
kjin merged 1 commit intogoogleapis:masterfrom Jun 22, 2018
Merged
Conversation
googlebot
added
the
cla: yes
kjin
force-pushed
the
new-api
branch
3 times, most recently
from
2ce40ca to
9a9e43b
Compare
DominicKramer
approved these changes
Jun 21, 2018
| // In v3, this will be deprecated for getCurrentRootSpan. | ||
| const traceContext = this.getCurrentRootSpan().getTraceContext(); | ||
| const parsedTraceContext = util.parseContextFromHeader(traceContext); | ||
| if (parsedTraceContext) { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds two methods on the TraceAgent class,
getProjectIdandgetCurrentRootSpan, which should supercedegetWriterProjectIdandgetCurrentContextIdrespectively. It also usesTraceWriter#projectIdinstead ofTraceWriter#config.projectIdto store the retrieved project ID, because this is already the behavior ofService. In practice, this fixes a regression withgetProjectId.