This repository was archived by the owner on Jan 21, 2026. It is now read-only.
chore: drop support for node 4 and 9#780
Merged
kjin merged 1 commit intogoogleapis:masterfrom Jul 9, 2018
Merged
Conversation
googlebot
added
the
cla: yes
ofrobots
reviewed
Jun 20, 2018
Contributor
ofrobots
left a comment
ofrobots
left a comment
There was a problem hiding this comment.
- update the package.json engines field.
- Make this commit and PR as semver-major.
kjin
changed the title
Contributor
Author
|
@ofrobots Done |
ofrobots
approved these changes
Jun 20, 2018
Contributor
|
Depending on how long you think it would take to get the other semver major changes in in order to unblock this – it might be worthwhile to land semver majors onto a |
BREAKING CHANGE: This commit drops support for Node 4 and 9.
Contributor
Author
|
I will land this on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: This change drops support for Node 4 and 9.
r-i-t-m needs to be fixed at 2.2.1. Tracking this at #779.
Actually, I do not want this to land yet.