This repository was archived by the owner on Jan 21, 2026. It is now read-only.
feat: support tracing for untranspiled async/await in Node 8+#775
Merged
kjin merged 1 commit intogoogleapis:masterfrom Jun 28, 2018
Merged
feat: support tracing for untranspiled async/await in Node 8+#775kjin merged 1 commit intogoogleapis:masterfrom
kjin merged 1 commit intogoogleapis:masterfrom
Conversation
googlebot
added
the
cla: yes
kjin
force-pushed
the
ah-default-v3
branch
2 times, most recently
from
6a752f9 to
6e97a72
Compare
kjin
commented
Jun 14, 2018
| "@types/is": "0.0.20", | ||
| "@types/methods": "^1.1.0", | ||
| "@types/mocha": "^5.0.0", | ||
| "@types/mocha": "5.2.1", |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
Author
|
@ofrobots Yes. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #566
This PR removes references to
GCLOUD_TRACE_NEW_CONTEXT. Code that depend on its value now behave as if it were alwaystrue.This change makes
async_hooks-based tracing the default behavior in Node 8+.