This repository was archived by the owner on Jan 21, 2026. It is now read-only.
feat: allow timestamps to be passed to endSpan#747
Merged
kjin merged 3 commits intogoogleapis:masterfrom May 14, 2018
Merged
Conversation
googlebot
added
the
cla: yes
ofrobots
approved these changes
May 14, 2018
| const spanData = new CommonSpanData(trace, 'name', '0', 0); | ||
| const startTime = new Date(spanData.span.startTime).getTime(); | ||
| // This input Date is far enough in the future that it's unlikely that the | ||
| // timethis function was called could be close to it. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #456
This PR adds an option to specify a time when a given span should be ended.