Skip to content
This repository was archived by the owner on Jan 21, 2026. It is now read-only.

fix: add build/src/cls in output files#736

Merged
kjin merged 1 commit intogoogleapis:masterfrom
kjin:package-json
May 2, 2018
Merged

fix: add build/src/cls in output files#736
kjin merged 1 commit intogoogleapis:masterfrom
kjin:package-json

Conversation

@kjin
Copy link
Copy Markdown
Contributor

@kjin kjin commented May 2, 2018

No description provided.

@kjin kjin requested review from DominicKramer, jinwoo and ofrobots May 2, 2018 22:32
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 2, 2018
ofrobots
ofrobots approved these changes May 2, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@ofrobots ofrobots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as this fixes a bogus release.

Looking over the list, it is not clear to me why the list of cherry-picked .d.ts files is sufficient. At any point a new file may be added that these files depend upon. I would like to see a more 'obviously correct' solution the problem of what types get shipped, e.g. a wildcard pattern for types.

@kjin kjin merged commit 49a900a into googleapis:master May 2, 2018
@kjin
Copy link
Copy Markdown
Contributor Author

kjin commented May 2, 2018

@ofrobots It's the list of "reachable" d.ts definitions from index.d.ts. This is being detected by the install test which is run on each PR, since it type-checks (and only type-checks, not runs) the statement import * as trace from '@google-cloud/trace-agent'. What we could do to avoid the much more important problem of ensuring that the correct .js files are included is to actually run the code in the install test.

@release-please release-please Bot mentioned this pull request Jun 30, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jinwoo jinwoo Awaiting requested review from jinwoo

@DominicKramer DominicKramer Awaiting requested review from DominicKramer

1 more reviewer

@ofrobots ofrobots ofrobots approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kjin @ofrobots @googlebot