This repository was archived by the owner on Jan 21, 2026. It is now read-only.
fix: restore context when a function run with a given context throws#727
Merged
kjin merged 2 commits intogoogleapis:masterfrom Apr 19, 2018
Merged
fix: restore context when a function run with a given context throws#727kjin merged 2 commits intogoogleapis:masterfrom
kjin merged 2 commits intogoogleapis:masterfrom
Conversation
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #727 +/- ##
=======================================
Coverage 90.74% 90.74%
=======================================
Files 30 30
Lines 1556 1556
Branches 304 304
=======================================
Hits 1412 1412
Misses 61 61
Partials 83 83
Continue to review full report at Codecov.
|
jinwoo
approved these changes
Apr 19, 2018
jinwoo
reviewed
Apr 19, 2018
| return res; | ||
| try { | ||
| const res = fn(); | ||
| return res; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
ofrobots
approved these changes
Apr 19, 2018
Contributor
ofrobots
left a comment
ofrobots
left a comment
There was a problem hiding this comment.
LGTM once the existing nit is addressed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses a TODO from #708: in two different cases, a function is accepted by the tracing API; we currently do not do any restoration of context if that function throws (in other words, the newly added tests would fail). This PR addresses that.