Skip to content
This repository was archived by the owner on Jan 21, 2026. It is now read-only.

test: fix system test#723

Merged
kjin merged 1 commit intomasterfrom
fix-system-tests
Apr 16, 2018
Merged

test: fix system test#723
kjin merged 1 commit intomasterfrom
fix-system-tests

Conversation

@kjin
Copy link
Copy Markdown
Contributor

@kjin kjin commented Apr 16, 2018

System tests fail often (but not always) because they rely on an authentication call being traced, when this is highly dependent on timing conditions (authentication needs to happen after the first call is made).

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 16, 2018
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 16, 2018

Codecov Report

Merging #723 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #723   +/-   ##
=======================================
  Coverage   90.74%   90.74%           
=======================================
  Files          28       28           
  Lines        1491     1491           
  Branches      294      294           
=======================================
  Hits         1353     1353           
  Misses         59       59           
  Partials       79       79

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59fabcc...f180fd7. Read the comment docs.

@kjin kjin changed the title [wip] test: fix system test test: fix system test Apr 16, 2018
Comment thread scripts/index.ts
const [, , ...steps] = process.argv;
const {
CI_PULL_REQUEST,
CIRCLE_PR_NUMBER,

This comment was marked as spam.

This comment was marked as spam.

@kjin kjin merged commit e5a4d76 into master Apr 16, 2018
@kjin kjin deleted the fix-system-tests branch April 16, 2018 22:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants