This repository was archived by the owner on Jan 21, 2026. It is now read-only.
fix: allow non-objects for plugins to disable automatic tracing#720
Merged
kjin merged 4 commits intogoogleapis:masterfrom Apr 10, 2018
Merged
fix: allow non-objects for plugins to disable automatic tracing#720kjin merged 4 commits intogoogleapis:masterfrom
kjin merged 4 commits intogoogleapis:masterfrom
Conversation
googlebot
added
the
cla: yes
kjin
force-pushed
the
disable-monkeypatch
branch
from
23331f8 to
5259f57
Compare
ofrobots
reviewed
Apr 9, 2018
Contributor
ofrobots
left a comment
ofrobots
left a comment
There was a problem hiding this comment.
Looking good, if you add tests.
Codecov Report
@@ Coverage Diff @@
## master #720 +/- ##
=======================================
Coverage 90.74% 90.74%
=======================================
Files 28 28
Lines 1491 1491
Branches 294 294
=======================================
Hits 1353 1353
Misses 59 59
Partials 79 79
Continue to review full report at Codecov.
|
Contributor
Author
|
@ofrobots PTAL |
ofrobots
reviewed
Apr 9, 2018
| const config = extend( | ||
| true, {[FORCE_NEW]: projectConfig[FORCE_NEW]}, defaultConfig, | ||
| envSetConfig, projectConfig, envConfig); | ||
| envSetConfig, projectConfig, envConfig, {plugins: {/**/}}); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #719
This change allows users to disable automatic tracing by passing a non-object value (such as
false) for the value ofconfig.plugins. It takes advantage ofextend's behavior of allowing non-object values to override object values, and vice versa.Since we do not recommend disabling plugins I have not documented this feature.