This repository was archived by the owner on Jan 21, 2026. It is now read-only.
refactor: avoid semver where possible#1309
Merged
bcoe merged 7 commits intogoogleapis:masterfrom Feb 3, 2021
Merged
Conversation
google-cla
Bot
added
the
cla: yes
JustinBeckwith
approved these changes
Sep 19, 2020
Contributor
JustinBeckwith
left a comment
JustinBeckwith
left a comment
There was a problem hiding this comment.
Thanks for this! I'm curious - did you see other places we were using the module? Wondering if we can remove it from package.json all together.
product-auto-label
Bot
added
the
api: cloudtrace
Contributor
Author
Contributor
|
👋 most folks do not have I'd be open to dropping the SemVer dependency, but I would want to see it instead replaced with logic that checks the major version, like this. |
Contributor
|
@TrySound this has stalled for a little while, did you have any interested in updating the PR to still throw on unsupported engine versions? |
Contributor
Author
|
Oops, sorry. Forgot about it. Will update today. |
Checking node version is not necessary anymore with "engines" field in package.json which prevents from installing this package with legacy node.
TrySound
force-pushed
the
avoid-semver
branch
from
c92986a to
8a82f78
Compare
Contributor
|
@TrySound looks reasonable to me, could I just bother you to run |
Contributor
Author
|
Contributor
Author
|
Hm... fix does not have any effect |
bcoe
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
gcf-merge-on-green Bot
pushed a commit
that referenced
this pull request
Feb 4, 2021
🤖 I have created a release \*beep\* \*boop\* --- ### [5.1.2](https://www.github.com/googleapis/cloud-trace-nodejs/compare/v5.1.1...v5.1.2) (2021-02-04) ### Performance Improvements * **deps:** avoid semver where possible ([#1309](https://www.github.com/googleapis/cloud-trace-nodejs/issues/1309)) ([4c05cae](https://www.github.com/googleapis/cloud-trace-nodejs/commit/4c05caeb3910657b3eb413da61aac03cb321bd7b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checking node version is not necessary anymore with "engines" field in
package.json which prevents from installing this package with legacy node.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕