fix: sample app TypeError#1257
Conversation
App sample has error: TypeError: The `GET` method cannot be used with a body This pull request is to update the body to an json response option
googlebot
added
the
cla: yes
|
failing Windows tests are being discussed here: |
|
@bcoe To move forward while the Node issues in question gets resolved (new Node version or new needle version), would it make sense to pin Node on Windows to 12.16.2 here? https://github.com/googleapis/cloud-trace-nodejs/blob/master/.github/workflows/ci.yaml#L61 |
|
@kintel yes, I would just switch to Node 10 on this branch for the purposes of landing. I believe the upstream issue will be fixed soon in Node. |
|
Nice fix! One question though - are we missing an integration test for the sample? I'm a little surprised this didn't get captured in the end to end test. |
|
@JustinBeckwith technically there is a test, but the test just checks that the process starts, not that it does the right thing. We should probably open a separate issue for improving the test. |
|
Opened follow-up issue: #1259 |
kintel
added
the
automerge
5 participants
App sample has error: TypeError: The
GETmethod cannot be used with a bodyThis pull request is to update the body to an json response option
Fixes #1246 🦕