This repository was archived by the owner on Jan 21, 2026. It is now read-only.
build: don't overwrite ci.yml, retire .circleci#1228
Merged
JustinBeckwith merged 1 commit intomasterfrom Mar 31, 2020
Merged
Conversation
googlebot
added
the
cla: yes
kjin
approved these changes
Mar 31, 2020
Contributor
kjin
left a comment
kjin
left a comment
There was a problem hiding this comment.
LGTM, although couldn't you synthtool.replace to re-substitute the necessary additions for running with containers? (I guess maybe it's not worth the trouble?)
Contributor
Author
|
@kjin fair point, re: replace, I think in this case I'm comfortable carving out an exception though, vs., needing to get too fancy with a replacement. |
JustinBeckwith
approved these changes
Mar 31, 2020
yoshi-automation
added a commit
that referenced
this pull request
Apr 1, 2020
1a66a42 commit 1a66a42 Author: Benjamin E. Coe <[email protected]> Date: Tue Mar 31 16:06:09 2020 -0700 build: don't overwrite ci.yml, retire .circleci (#1228)
Mistic92
pushed a commit
to Mistic92/cloud-trace-nodejs
that referenced
this pull request
Apr 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
now that GitHub actions are working: