Skip to content
This repository was archived by the owner on Jan 21, 2026. It is now read-only.

docs: document version support goals#1222

Merged
bcoe merged 2 commits intomasterfrom
version-support-readme
Mar 30, 2020
Merged

docs: document version support goals#1222
bcoe merged 2 commits intomasterfrom
version-support-readme

Conversation

@bcoe
Copy link
Copy Markdown
Contributor

@bcoe bcoe commented Mar 24, 2020

No description provided.

@bcoe bcoe requested a review from alexander-fenster March 24, 2020 00:28
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 24, 2020
@sofisl sofisl added the automerge Merge the pull request once unit tests and other checks pass. label Mar 24, 2020
@bcoe bcoe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 24, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 24, 2020
@bcoe bcoe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 24, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 24, 2020
@gcf-merge-on-green
Copy link
Copy Markdown
Contributor

gcf-merge-on-green Bot commented Mar 24, 2020

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

3 similar comments
@gcf-merge-on-green
Copy link
Copy Markdown
Contributor

gcf-merge-on-green Bot commented Mar 24, 2020

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@gcf-merge-on-green
Copy link
Copy Markdown
Contributor

gcf-merge-on-green Bot commented Mar 24, 2020

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@gcf-merge-on-green
Copy link
Copy Markdown
Contributor

gcf-merge-on-green Bot commented Mar 24, 2020

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@gcf-merge-on-green
Copy link
Copy Markdown
Contributor

gcf-merge-on-green Bot commented Mar 24, 2020

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 30, 2020 •
edited
Loading

Codecov Report

Merging #1222 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1222      +/-   ##
==========================================
- Coverage   94.73%   94.65%   -0.09%     
==========================================
  Files         100      100              
  Lines        6551     6490      -61     
  Branches      514      514              
==========================================
- Hits         6206     6143      -63     
- Misses        182      184       +2     
  Partials      163      163
Impacted Files Coverage Δ
.mocharc.js 62.5% <0%> (-25%) ⬇️
test/web-frameworks/connect.ts 76.92% <0%> (-0.86%) ⬇️
test/test-cls-ah.ts 90.12% <0%> (-0.69%) ⬇️
test/web-frameworks/hapi17.ts 92.3% <0%> (-0.38%) ⬇️
test/web-frameworks/hapi8_16.ts 90.47% <0%> (-0.23%) ⬇️
test/test-grpc-async-handler.ts 97.01% <0%> (-0.17%) ⬇️
test/test-trace-web-frameworks.ts 98.72% <0%> (-0.12%) ⬇️
test/plugins/test-cls-bluebird.ts 96.77% <0%> (-0.11%) ⬇️
test/test-trace-hapi-tails.ts 97.91% <0%> (-0.09%) ⬇️
test/trace.ts 93.5% <0%> (-0.09%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ccfeb2...b2299d1. Read the comment docs.

@bcoe bcoe merged commit 644adaa into master Mar 30, 2020
@bcoe bcoe deleted the version-support-readme branch March 30, 2020 18:40
yoshi-automation added a commit that referenced this pull request Apr 1, 2020
@yoshi-automation
docs: document version support goals (#1222)
11ea071 
644adaa
commit 644adaa
Author: Benjamin E. Coe <[email protected]>
Date:   Mon Mar 30 11:40:16 2020 -0700

    docs: document version support goals (#1222)

    Co-authored-by: Justin Beckwith <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@alexander-fenster alexander-fenster Awaiting requested review from alexander-fenster

1 more reviewer

@sofisl sofisl sofisl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bcoe @sofisl @googlebot @yoshi-kokoro @JustinBeckwith