This repository was archived by the owner on Jan 21, 2026. It is now read-only.
docs(README): Update hapi version supported#1210
Merged
gcf-merge-on-green[bot] merged 6 commits intogoogleapis:masterfrom Apr 11, 2020
Merged
docs(README): Update hapi version supported#1210gcf-merge-on-green[bot] merged 6 commits intogoogleapis:masterfrom
gcf-merge-on-green[bot] merged 6 commits intogoogleapis:masterfrom
Conversation
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #1210 +/- ##
=========================================
Coverage ? 94.69%
=========================================
Files ? 99
Lines ? 6482
Branches ? 514
=========================================
Hits ? 6138
Misses ? 181
Partials ? 163
Continue to review full report at Codecov.
|
kjin
approved these changes
Mar 2, 2020
bcoe
added
the
automerge
Contributor
|
Your PR was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. See required reviews for your repo here: https://github.com/googleapis/sloth/blob/master/required-checks.json |
Contributor
|
Is version 19 also actually tested? I can't really tell from the tests but I think only 17 and maybe 18 are tested? |
JustinBeckwith
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
yoshi-automation
added a commit
that referenced
this pull request
Apr 11, 2020
Source-Repo: googleapis/cloud-trace-nodejs Source-Sha: 14fd9c8 Source-Link: 14fd9c8 Author: Santi <[email protected]> Date: Sat Apr 11 10:22:31 2020 +0200 Original-Commit-Message: docs(README): Update hapi version supported (#1210) Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/cloud-trace-nodejs/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [x] Ensure the tests and linter pass - [x] Code coverage does not decrease (if any source code was changed) - [x] Appropriate docs were updated (if necessary) Fixes #1193 🦕
yoshi-automation
added a commit
that referenced
this pull request
Apr 12, 2020
Source-Repo: googleapis/cloud-trace-nodejs Source-Sha: 14fd9c8 Source-Link: 14fd9c8 Author: Santi <[email protected]> Date: Sat Apr 11 10:22:31 2020 +0200 Original-Commit-Message: docs(README): Update hapi version supported (#1210) Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/cloud-trace-nodejs/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [x] Ensure the tests and linter pass - [x] Code coverage does not decrease (if any source code was changed) - [x] Appropriate docs were updated (if necessary) Fixes #1193 🦕
yoshi-automation
added a commit
that referenced
this pull request
Apr 14, 2020
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/cloud-trace-nodejs/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [x] Ensure the tests and linter pass - [x] Code coverage does not decrease (if any source code was changed) - [x] Appropriate docs were updated (if necessary) Fixes #1193 🦕 Source-Author: Santi <[email protected]> Source-Date: Sat Apr 11 10:22:31 2020 +0200 Source-Repo: googleapis/cloud-trace-nodejs Source-Sha: 14fd9c8 Source-Link: 14fd9c8
yoshi-automation
added a commit
that referenced
this pull request
Apr 15, 2020
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/cloud-trace-nodejs/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [x] Ensure the tests and linter pass - [x] Code coverage does not decrease (if any source code was changed) - [x] Appropriate docs were updated (if necessary) Fixes #1193 🦕 Source-Author: Santi <[email protected]> Source-Date: Sat Apr 11 10:22:31 2020 +0200 Source-Repo: googleapis/cloud-trace-nodejs Source-Sha: 14fd9c8 Source-Link: 14fd9c8
Mistic92
pushed a commit
to Mistic92/cloud-trace-nodejs
that referenced
this pull request
Apr 15, 2020
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/cloud-trace-nodejs/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [x] Ensure the tests and linter pass - [x] Code coverage does not decrease (if any source code was changed) - [x] Appropriate docs were updated (if necessary) Fixes googleapis#1193 🦕
yoshi-automation
added a commit
that referenced
this pull request
Apr 16, 2020
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/cloud-trace-nodejs/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [x] Ensure the tests and linter pass - [x] Code coverage does not decrease (if any source code was changed) - [x] Appropriate docs were updated (if necessary) Fixes #1193 🦕 Source-Author: Santi <[email protected]> Source-Date: Sat Apr 11 10:22:31 2020 +0200 Source-Repo: googleapis/cloud-trace-nodejs Source-Sha: 14fd9c8 Source-Link: 14fd9c8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #1193 🦕