Skip to content
This repository was archived by the owner on Jan 21, 2026. It is now read-only.

fix(deps): pin TypeScript below 3.7.0#1163

Merged
kjin merged 1 commit intomasterfrom
pin-typescript
Dec 6, 2019
Merged

fix(deps): pin TypeScript below 3.7.0#1163
kjin merged 1 commit intomasterfrom
pin-typescript

Conversation

@bcoe
Copy link
Copy Markdown
Contributor

@bcoe bcoe commented Dec 5, 2019

No description provided.

@bcoe bcoe requested a review from JustinBeckwith December 5, 2019 01:48
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 5, 2019
@bcoe
Copy link
Copy Markdown
Contributor Author

bcoe commented Dec 5, 2019

@kjin 👋 unfortunately, [email protected] is not compatible with 3.5.3 (which is the version Angular is pinned to, and a lot of our users use).

Any thoughts on the failing circle-ci tests here?

@kjin
Copy link
Copy Markdown
Contributor

kjin commented Dec 6, 2019

@bcoe I was OOO yesterday, will look at them today. Thanks for the reminder!

If it's urgent, please force-merge this PR.

@bcoe
Copy link
Copy Markdown
Contributor Author

bcoe commented Dec 6, 2019

@kjin I would say medium urgent, it means our TypeScript folks on Angular can't run trace; I don't have permission to force push unfortunately.

@kjin kjin merged commit 6448c94 into master Dec 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants