Skip to content
This repository was archived by the owner on Jan 21, 2026. It is now read-only.

feat: support @hapi/hapi#1108

Merged
kjin merged 1 commit intogoogleapis:masterfrom
kjin:hh
Sep 3, 2019
Merged

feat: support @hapi/hapi#1108
kjin merged 1 commit intogoogleapis:masterfrom
kjin:hh

Conversation

@kjin
Copy link
Copy Markdown
Contributor

@kjin kjin commented Aug 26, 2019

Fixes #1107

This PR adds support for hapi 18 (now @hapi/hapi).

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 26, 2019
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 27, 2019

Codecov Report

Merging #1108 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1108      +/-   ##
==========================================
+ Coverage   94.99%   94.99%   +<.01%     
==========================================
  Files          98       98              
  Lines        6450     6451       +1     
  Branches      499      500       +1     
==========================================
+ Hits         6127     6128       +1     
  Misses        166      166              
  Partials      157      157
Impacted Files Coverage Δ
src/plugins/plugin-hapi.ts 92% <ø> (ø) ⬆️
src/config.ts 100% <ø> (ø) ⬆️
test/test-trace-web-frameworks.ts 98.83% <100%> (ø) ⬆️
test/test-config-plugins.ts 100% <100%> (ø) ⬆️
test/web-frameworks/hapi17.ts 92.68% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84f9229...3baf3a8. Read the comment docs.

1 similar comment
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 27, 2019

Codecov Report

Merging #1108 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1108      +/-   ##
==========================================
+ Coverage   94.99%   94.99%   +<.01%     
==========================================
  Files          98       98              
  Lines        6450     6451       +1     
  Branches      499      500       +1     
==========================================
+ Hits         6127     6128       +1     
  Misses        166      166              
  Partials      157      157
Impacted Files Coverage Δ
src/plugins/plugin-hapi.ts 92% <ø> (ø) ⬆️
src/config.ts 100% <ø> (ø) ⬆️
test/test-trace-web-frameworks.ts 98.83% <100%> (ø) ⬆️
test/test-config-plugins.ts 100% <100%> (ø) ⬆️
test/web-frameworks/hapi17.ts 92.68% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84f9229...3baf3a8. Read the comment docs.

@kjin kjin marked this pull request as ready for review August 27, 2019 17:05
@kjin kjin requested a review from a team August 27, 2019 17:05
@soldair soldair self-requested a review September 3, 2019 21:31
Copy link
Copy Markdown
Contributor

@soldair soldair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kjin kjin merged commit d545e93 into googleapis:master Sep 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support hapi@18

3 participants